Put #[cfg] in backticks.
#11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bare `[cfg]` makes rustdoc nightly complain.
Merged
|
With the current nightly it won't even document the crate, could this be merged? |
This was referenced Jun 25, 2018
Closed
|
alex will be back at the end of the month, this will have to wait until then, sorry for the inconvenience |
|
@goffrie thank you for the PR. The other PRs also bumps the version and it will be quicker to merge that one and just do a new release afterwards. Would you be willing to close this PR so that there is only one about this issue open? (might help speed things up once alex is back, his TODO list will be... pretty large...). |
|
For anyone who want the create docs in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bare
[cfg]makes rustdoc nightly complain.