Skip to content

Make chalk_solve::Solver UnwindSafe #260

@matklad

Description

@matklad

In rust-analyzer, we use panics to implement cancellation. That means that, while we use chalk to solve some goal, the callbacks from chalk into rust-analyzer might panic, unwinding past the Solver.

This unfortunately leaves the solver in an inconsistent state at the moment. See https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Logic.20panics for some more details.

This issue has been assigned to @marmeladema via this comment.

Metadata

Metadata

Assignees

Labels

good first issueA good issue to start working on Chalk with

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions