extend chalk TypeName with builtin types

[nikomatsakis]

The TypeName enum needs to be extended to cover the "built-in" types from Rust. The following variants would eventually want to be added:

• scalar types:
  • unsigned integer types (u32, u64, usize, etc)
  • signed integer types
  • bool
  • char
• tuple types (parameterized by arity, so Tuple(usize))
• str -- see extend TypeName with str type #437
• reference types & and &mut -- create TypeName for & and &mut #438
• raw pointer types * const and *mut -- create typename for raw pointers #439
• array types (requires const work to land)
• slice type -- extend TypeName with slice type #440
• FnDef (PR: Add FnDef to TypeName #449)
• Never
• Closure
• generator/ generator witness -- Implement generators #593, create a "generator witness" type #504
• generalize the builtin struct type to adt to match rustc #453: generalize struct to enum/union
• Support for multiple variants on Adt -- extend chalk ADTs with information about variants #505
• Extern types -- Support extern opaque types. #595

(Need to update this list, not yet complete, see this section of the chalk book for a more complete list as well.

[MarkMcCaskey]

I'm interested in taking this on! I'll follow up with a PR

[MarkMcCaskey]

@rustbot claim

[basil-cow]

@MarkMcCaskey what's the status on this?

[MarkMcCaskey]

Sorry about the radio silence -- I've been busier than I anticipated recently and haven't had the spare focus to work on this. I haven't worked on closures or functions other than what was in the original PR yet. I can dedicate a bit of time to it this weekend and more time to it next week. If this is blocking other issues and/or if someone wants to implement it, I have no problem with someone else taking it on but I'd be happy to work on it otherwise!

[nikomatsakis]

@rustbot release-assignment

I think @MarkMcCaskey is busy, but also I'm going to break this into distinct issues.

[nikomatsakis]

OK, I broke out a number of issues thus far that people can pick up.

[nikomatsakis]

@rustbot release-assignment

This is a tracking issue, so it doesn't really need an assignee.

[vringar]

Could this issue be closed and the remaining items moved into #16 directly so there's a more centralized overview of what still needs to be done for a shared type library?

[AzureMarker]

@vringar Not sure if you linked to the right issue; that one is about checking kinds during lowering, from 2017.

[jackh726]

@vringar probably means rust-lang/types-team#16

I think keeping this open and linking to this from there is the best idea. Ultimately, yeah, there's not much left to here; but, I don't think it makes sense to put all the finer details there.

[vringar]

Sorry for fucking up the linking.
@jackh726 is right is the assumption but also in the resolution.
Sorry for creating noise.

[jackh726]

@vringar No worries!

[Aaron1011]

With PR #593, we now have Generator and GeneratorWitness. All of the types in this issue are now checked off - is there anything left to do here?

[jackh726]

@Aaron1011 nothing left to do here

Thanks everyone for all the work to get this done :)

[LeSeulArtichaut]

Should the work item associated to this issue in rust-lang/types-team#16 be checked?