Skip to content

Require where clauses from the impl on Normalize goal #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Require where clauses from the impl on Normalize goal #237

merged 1 commit into from
Sep 3, 2019

Conversation

flodiebold
Copy link
Member

This should fix #235.

(I also included the other test from #234 in ignored form, since I already had it there...)

@flodiebold
Copy link
Member Author

Build failure is apparently just formatting on nightly

scalexm
scalexm approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@scalexm scalexm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rustc-guide will need to be fixed too. I’ll probably take care of that.

@nikomatsakis
Copy link
Contributor

we should figure out this formatting business

@nikomatsakis nikomatsakis merged commit 5c6cea8 into rust-lang:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@scalexm scalexm scalexm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalization doesn't take into account which impl actually applied
3 participants
@flodiebold @nikomatsakis @scalexm