-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal builder #361
Merged
Merged
Goal builder #361
Commits on Mar 28, 2020
-
introduce GoalBuilder and convert struct WF goals
The goal here is to make this code more readable and less ad-hoc.
Configuration menu - View commit details
-
Copy full SHA for 1649c5c - Browse repository at this point
Copy the full SHA 1649c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 671e1e4 - Browse repository at this point
Copy the full SHA 671e1e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 413e582 - Browse repository at this point
Copy the full SHA 413e582View commit details -
Configuration menu - View commit details
-
Copy full SHA for acad3a4 - Browse repository at this point
Copy the full SHA acad3a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10013b1 - Browse repository at this point
Copy the full SHA 10013b1View commit details
Commits on Mar 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f099845 - Browse repository at this point
Copy the full SHA f099845View commit details
Commits on Mar 31, 2020
-
make associated type value goals standalone
For a GAT like ``` impl<T> Foo<T> { type Bar<'a> = ..} ``` Instead of constructing nested quantifiers like ``` forall<T> { if (..) { stuff && forall<'a> { more_stuff } } } ``` we will now build separate goals ``` forall<T> { if (...) { stuff } } && forall<T, 'a> { if (...) { more_stuff } } ``` This both removes the need for the 'partial' forall methods in GoalBuilder butalso means we would be able to give better error messages in rustc at somepoint, since we can test "is this impl header WF" separately from "is this associated type value WF" etc.
Configuration menu - View commit details
-
Copy full SHA for f319d6d - Browse repository at this point
Copy the full SHA f319d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab25299 - Browse repository at this point
Copy the full SHA ab25299View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4acecc2 - Browse repository at this point
Copy the full SHA 4acecc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d208e4e - Browse repository at this point
Copy the full SHA d208e4eView commit details
Commits on Apr 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b5040c2 - Browse repository at this point
Copy the full SHA b5040c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 271b4d6 - Browse repository at this point
Copy the full SHA 271b4d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4e623 - Browse repository at this point
Copy the full SHA fc4e623View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a6491b - Browse repository at this point
Copy the full SHA 7a6491bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32f4dc8 - Browse repository at this point
Copy the full SHA 32f4dc8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.