Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intern Vec<QuantifiedWhereClause<I>>. #379

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Intern Vec<QuantifiedWhereClause<I>>. #379

merged 1 commit into from
Apr 7, 2020

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Apr 7, 2020

cc #369 .

@crlf0710 crlf0710 mentioned this pull request Apr 7, 2020
Closed
5 tasks
nikomatsakis
nikomatsakis approved these changes Apr 7, 2020
View reviewed changes
chalk-ir/src/lib.rs
}
}

pub fn from_fallible<E>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting to be an annoying amount of boilerplate -- not to be addressed in this PR, but I wonder if we can cleanup and encapsulate this pattern better.

@nikomatsakis nikomatsakis merged commit 31ea6d8 into rust-lang:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crlf0710 @nikomatsakis