Migrate Vec<ParameterKinds<()>> and Vec<ParameterKinds<UniverseIndex>> to interned
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nikomatsakis
requested changes
Apr 13, 2020
|
@nikomatsakis Ok, i've rebased and reverted those changes. Ready for review again. |
nikomatsakis
approved these changes
Apr 13, 2020
nikomatsakis
requested changes
Apr 13, 2020
nikomatsakis
requested changes
Apr 13, 2020
|
Comments addressed. Ready for review again. |
nikomatsakis
approved these changes
Apr 14, 2020
| fn into_binders_and_value(self) -> (Self::Binders, Self::Value) { | ||
| (self.0.binders.iter(self.1).cloned(), self.0.skip_binders()) | ||
| fn into_binders_and_value(self, interner: &'a I) -> (Self::Binders, Self::Value) { | ||
| (self.binders.iter(interner).cloned(), self.skip_binders()) |
There was a problem hiding this comment.
Oh, I see, it's because we actually return an interior here -- well, this seems ok.
|
@crlf0710 can you rebase this PR? Then I'm inclined to merge! |
|
@nikomatsakis Sure, done! |
|
@crlf0710 uh oh, need one more rebase :) |
|
@nikomatsakis Done again :) |
nikomatsakis
requested changes
Apr 17, 2020
| // different from `^1.0` in terms of what variable is being | ||
| // referenced. | ||
| write!(fmt, "<")?; | ||
| for (index, binder) in self.parameter_kinds.iter(self.interner).enumerate() { |
There was a problem hiding this comment.
Wait, this code doesn't seem like it's in the right place. ParameterKinds are just a list of, well, parameter kinds. They are not themselves a binder... Ah, well, I guess every time they are used, it's as part of a binder... ok, seems reasonable. 👍
nikomatsakis
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #369 . But i guess some adjustment are needed.