Rename folding/visiting traits #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the force-push there. I tried to reorder the commits but it completely messed up the branch; didn't notice before pushing. Failing test is due to broken doc links but this commit will update those docs? Test should probably be against revised documentation, no? |
This was just fixed, so just ignore it in this PR. |
|
@bors r+ |
|
📌 Commit 23d39c9 has been approved by |
|
☀️ Test successful - checks-actions |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the names of chalk's folding/visiting traits with those in rustc (especially once rust-lang/rust#98206) is merged.
r? @jackh726