Add uses_cxx11 to builder to fix up default targets on OSX #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
tgross35
pushed a commit
that referenced
this pull request
Feb 10, 2025
The workaround introduced in #39 is no longer necessary since `cc-rs` handles C++ requirements internally, and is in fact detrimental since `cc-rs` has required the target to be a `rustc` target triple since rust-lang/cc-rs#1225 / rust-lang/cc-rs#1252. Additionally, deprecate `uses_cxx11` which was introduced in the same PR. Fixes rust-lang/cc-rs#1276. I didn't update the dependency to anything specific, just a version that I know has the fix.
This was referenced Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38