Skip to content

Removal of target dir required when adding symbols to compiler-rt-cdylib #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
est31 opened this issue Feb 3, 2017 · 1 comment · Fixed by #138 or #155
Closed

Removal of target dir required when adding symbols to compiler-rt-cdylib #136

est31 opened this issue Feb 3, 2017 · 1 comment · Fixed by #138 or #155

Comments

@est31
Copy link
Member

est31 commented Feb 3, 2017

I was attempting to add some new symbols to compiler-rt-cdylib. It worked, but the tests failed. I had to remove the target directory and do a clean re-build of the entire project to update the so file. This should not be required.
@est31 est31 mentioned this issue Feb 4, 2017
Merged
japaric pushed a commit that referenced this issue Feb 4, 2017
add rebuild logic to compiler-rt-cdylib
c08b169 
fixes #136
@japaric japaric mentioned this issue Feb 4, 2017
Merged
bors added a commit that referenced this issue Feb 4, 2017
@bors
Auto merge of #138 - rust-lang-nursery:cdylib-rebuild, r=japaric
0d0f22a 
add rebuild logic to compiler-rt-cdylib

fixes #136
@bors bors closed this as completed in #138 Feb 4, 2017
@est31
Copy link
Member Author

est31 commented Feb 4, 2017

@japaric travis says its still present: https://travis-ci.org/rust-lang-nursery/compiler-builtins/builds/198247070

can you reopen?

@japaric japaric reopened this Feb 4, 2017
@japaric japaric mentioned this issue Apr 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@japaric @est31