Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build missing intrinsics from compiler-rt (C) source code #63

Closed
2 tasks
japaric opened this issue Sep 14, 2016 · 2 comments · Fixed by #74
Closed
2 tasks

Build missing intrinsics from compiler-rt (C) source code #63

japaric opened this issue Sep 14, 2016 · 2 comments · Fixed by #74

Comments

@japaric
Copy link
Member

japaric commented Sep 14, 2016 •
edited
Loading

  • Add compiler-rt source code as a submodule. Use rust-lang/compiler-rt
  • Add an opt-in Cargo feature for this. We'll only compile the intrinsics from C code if the feature is enabled.
@japaric
Copy link
Member Author

japaric commented Sep 14, 2016

Alternative: we can use libgcc implementations (instead of compiler-rt's) on the platforms where that library is available.

@japaric japaric mentioned this issue Sep 14, 2016
Closed
8 tasks
@japaric
Copy link
Member Author

japaric commented Sep 15, 2016

We'll only compile the intrinsics from C code

This requires conditional compilation logic. Simply copy paste the logic from rust-lang/rust's src/libcompiler_builtins/build.rs

japaric pushed a commit that referenced this issue Sep 26, 2016
add an opt-in cargo feature to build intrinsics from compiler-rt source
310aaa9 
closes #63
cc #66
@japaric japaric mentioned this issue Sep 26, 2016
Merged
japaric pushed a commit that referenced this issue Sep 29, 2016
add an opt-in cargo feature to build intrinsics from compiler-rt source
f77ca91 
closes #63
cc #66
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this issue Feb 23, 2025
@bors @japaric
Merge rust-lang#63
667035f 
63: test source importing this crate r=japaric a=japaric



Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add an opt-in cargo feature to build intrinsics from compiler-rt source rust-lang/compiler-builtins
1 participant
@japaric