Skip to content

Better test harness #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattico opened this issue Sep 22, 2016 · 0 comments
Closed

Better test harness #72

mattico opened this issue Sep 22, 2016 · 0 comments

Comments

@mattico
Copy link
Contributor

mattico commented Sep 22, 2016

I'd like to have results like:

target: thumbv6m-none-eabi

Testing 123 intrinsics...
test muldi ... ok
test mulosi ... ok
test mulodi ... ok
test divdi3 ... ERROR
  input: (-1, INT_MAX)
  results:
    compiler-rt:       32768
    gcc_s:             32768
    compiler-builtins: 32767
test udivmoddi4 ... ERROR
  input: (25, 367)
  results:
    compiler-rt:       3
    gcc_s:             N/A
    compiler-builtins: 365
...

target: thumbv6m-none-eabi

Benchmarking 123 intrinsics...
bench muldi...
  compiler-rt:       16,386 ns/iter (+- 366)
  gcc_s:             14,375 ns/iter (+- 540)
  compiler-builtins: 17,690 ns/iter (+- 750)
bench mulosi...
...
This was referenced Sep 27, 2016
Merged
Merged
japaric pushed a commit that referenced this issue Oct 3, 2016
@homunkulus
Auto merge of #86 - mattico:multitester, r=japaric
954e3b7 
Initial implementation of multitester

Implements part of #72.

I wanted to work on this first because it should help me find the problem in the add implementation.

Test failures now look like this:
```
__addsf3 - Args: 1 1264853201
  rustc-builtins: Some(0)
  compiler_rt:    Some(14950609)
  gcc_s:          None
__addsf3 - Args: 1 632426600
  rustc-builtins: Some(0)
  compiler_rt:    Some(0.00000000000000030889195)
  gcc_s:          None
__addsf3 - Args: 1 316213300
  rustc-builtins: Some(0)
  compiler_rt:    Some(0.0000000000000000000000000013696648)
  gcc_s:          None

[snip]

thread 'float::add::tests::_test::__addsf3' panicked at '[quickcheck] TEST FAILED. Arguments: (1, 1)', /home/matt/.cargo/registry/src/github.com-1ecc6299db9ec823/quickcheck-0.3.1/src/tester.rs:118
```

It currently prints all of the errors, if that's undesirable we'd need to remove the shrinkers or modify quickcheck.
@mattico mattico closed this as completed Jun 25, 2017
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this issue Feb 23, 2025
@bors @japaric
Merge rust-lang#72
6084dad 
72: move a chunk of the README into CONTRIBUTING.md r=japaric a=japaric



Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattico