Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim the list of fallbacks in compiler-rt #78

Closed
alexcrichton opened this issue Sep 30, 2016 · 2 comments
Closed

Trim the list of fallbacks in compiler-rt #78

alexcrichton opened this issue Sep 30, 2016 · 2 comments

Comments

@alexcrichton
Copy link
Member

Added in #74, the c feature enables building a bunch of compiler-rt intrinsics.

Right now the list is pretty huge and I think we definitely don't need a good number of these like:

  • emutls.c
  • gcc_personality_v0.c

etc

It looks like there's already a list of crossed off functions, maybe those could all be excluded?

@adlerd
Copy link

adlerd commented Mar 14, 2017

Worse, some of the included files depend on other, nonincluded files (not always explicitly; sometimes via intrinsics themselves, it seems).

For example, enabling feature "c" targeting aarch64 results in

$HOME/.cargo/git/checkouts/compiler-builtins-ec094dc45a0179c8/0507842/./compiler-rt/compiler-rt-cdylib/compiler-rt/lib/builtins/mulxc3.c:71: undefined reference to `__multf3'

among a dozen other link errors.

@alexcrichton
Copy link
Member Author

I think this is effectively done now, we've got lots of testing for duplicate symbols and the list is getting smaller, so closing.

tgross35 pushed a commit to tgross35/compiler-builtins that referenced this issue Feb 23, 2025
78: force PR code to be formatted r=japaric a=japaric



Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants