Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define VISIBILITY_HIDDEN when compiling objects #119

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

alexcrichton
Copy link
Member

Apparently compiler-rt passed this and we just forgot to. Fixes visibility of
some symbols on 32-bit Linux.

Apparently compiler-rt passed this and we just forgot to. Fixes visibility of
some symbols on 32-bit Linux.
@japaric
Copy link
Member

japaric commented Nov 18, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2016

📌 Commit 24d4907 has been approved by japaric

@bors
Copy link
Contributor

bors commented Nov 18, 2016

⌛ Testing commit 24d4907 with merge 5c8f086...

bors added a commit that referenced this pull request Nov 18, 2016
Define VISIBILITY_HIDDEN when compiling objects

Apparently compiler-rt passed this and we just forgot to. Fixes visibility of
some symbols on 32-bit Linux.
@bors
Copy link
Contributor

bors commented Nov 19, 2016

💥 Test timed out

@japaric
Copy link
Member

japaric commented Nov 19, 2016

Travis error:

Downloading https://static.rust-lang.org/dist/2016-11-18/rustc-nightly-src.tar.gz
error: Couldn't fetch Rust source tarball

Was there no source release yesterday? (Xargo uses that tarball)

@alexcrichton
Copy link
Member Author

@bors: retry

Looks like today's nightlies have sources?

@bors
Copy link
Contributor

bors commented Nov 20, 2016

⌛ Testing commit 24d4907 with merge 4c87581...

bors added a commit that referenced this pull request Nov 20, 2016
Define VISIBILITY_HIDDEN when compiling objects

Apparently compiler-rt passed this and we just forgot to. Fixes visibility of
some symbols on 32-bit Linux.
@bors
Copy link
Contributor

bors commented Nov 21, 2016

💥 Test timed out

@alexcrichton alexcrichton merged commit fbf5195 into rust-lang:master Nov 21, 2016
@alexcrichton alexcrichton deleted the hidden branch November 21, 2016 15:27
@alexcrichton
Copy link
Member Author

Still need to debug what's what with bors...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants