Define VISIBILITY_HIDDEN when compiling objects #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently compiler-rt passed this and we just forgot to. Fixes visibility of some symbols on 32-bit Linux.
|
@bors r+ |
|
📌 Commit 24d4907 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 18, 2016
Define VISIBILITY_HIDDEN when compiling objects Apparently compiler-rt passed this and we just forgot to. Fixes visibility of some symbols on 32-bit Linux.
|
💥 Test timed out |
|
Travis error:
Was there no source release yesterday? (Xargo uses that tarball) |
|
@bors: retry Looks like today's nightlies have sources? |
bors
added a commit
that referenced
this pull request
Nov 20, 2016
Define VISIBILITY_HIDDEN when compiling objects Apparently compiler-rt passed this and we just forgot to. Fixes visibility of some symbols on 32-bit Linux.
|
💥 Test timed out |
|
Still need to debug what's what with bors... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently compiler-rt passed this and we just forgot to. Fixes visibility of
some symbols on 32-bit Linux.