Refactor Float implementation #170
Closed
+136
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the Wrapping() type from the Add impl, and uses a macro to implement the Float trait.
|
Part of #169 |
|
I'll take a look at those errors later. |
|
☔ The latest upstream changes (presumably #181) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing for now. May have motivation to update this at some point. |
|
@mattico can I pick up your PR to work on the issue? If you want to do it yourself, please be my guest! |
|
@est31 go for it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Wrapping() type from the Add impl, and uses a macro to implement the Float trait.
I think I can change the float macros into traits as well, but that requires a bit more finesse, so I'll leave that for later.