Implement __mulsi3. #251
Merged
Implement __mulsi3. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
suggested changes
Jul 27, 2018
src/lib.rs
Outdated
| @@ -58,6 +58,9 @@ pub mod arm; | |||
| #[cfg(all(kernel_user_helpers, target_os = "linux", target_arch = "arm"))] | |||
| pub mod arm_linux; | |||
|
|
|||
| #[cfg(any(target_arch = "riscv32", target_arch = "riscv64"))] | |||
There was a problem hiding this comment.
NOTE: we'll be submitting a PR to rust-lang/rust that adds these two target architectures.
src/riscv.rs
Outdated
| // Implementation from gcc | ||
| // https://raw.githubusercontent.com/gcc-mirror/gcc/master/libgcc/config/epiphany/mulsi3.c | ||
| #[cfg_attr(not(feature = "mangled-names"), no_mangle)] | ||
| pub unsafe extern "C" fn __mulsi3(mut a: usize, mut b: usize) -> usize { |
There was a problem hiding this comment.
The signature should be fn(u32, u32) -> u32 to match the linked source. (iirc, "si" is used for 32-bit ops; "di" is used for 64-bit ops; etc.).
|
Thanks for the PR! Could this use the |
|
@japaric @alexcrichton Is this ok to merge? It's not required by |
japaric
approved these changes
Aug 3, 2018
|
Thanks @dvc94ch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds __mulsi3 intrinsic for RISCV target required when no hardware multiplication unit is available.
PR adding riscv support to rust: rust-lang/rust#52787