Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't force-on c feature when working in rustc workspace #289

Merged
merged 1 commit into from
May 14, 2019

Conversation

RalfJung
Copy link
Member

libstd turns on c in it's Cargo.toml. That should be enough. Is there a way to verify this?

Fixes #288

@alexcrichton alexcrichton merged commit e0e54de into rust-lang:master May 14, 2019
@alexcrichton
Copy link
Member

FWIW after some digging alloc as well will need to enable the c feature

@RalfJung
Copy link
Member Author

I could mirror std's setup -- but care to elaborate why? Shouldn't it be enough to do that in one place?

@alexcrichton
Copy link
Member

There's a branch in rustbuild which special cases no-std targets where we only compile the alloc crate and its dependencies for those target, not std and below. The std crate by default enables the C feature of compiler-builtins but the alloc crate doesn't currently. It's also fine to just centralize the logic in the alloc crate though.

@RalfJung RalfJung deleted the c branch August 23, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should rustc-dep-of-std feature really depend on c?
2 participants