Do not use atomic reads on platforms without atomic support in LLVM. Fixes #441. #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still would like to test this patch against my own code, and I've asked for clarification on how to do that. However, I have confirmed this fix works locally by building
libcore
. The command used to build in both cases was:Before Patch
After Patch
The patch points to my local
compiler_builtins
with this PR's Commits:I would like to test this against my own code, but this is probably "good enough" for merging if you don't want/need any further changes.