-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add weak linkage to the ARM AEABI division functions #478
Conversation
Note: It was mentioned in the issue that these functions are also incorrect on v4T. I'll resolve that as a separate PR so that we're just talking about one thing at a time. |
I didn't touch those memory functions, so the test error seem unrelated. |
@Amanieu ping |
Sorry about the delay, I'm still looking into the powerpc issue. It seems like it might be an LLVM regression. |
CI should be fixed now, could you rebase on the latest master? |
Could you make the weak linkage conditional on |
updates from main
do you detect for apple like this? #[cfg_attr(all(not(windows), not(target_vendor="apple")), linkage = "weak")] or something else? |
Yes, that's correct. |
on windows and apple (which don't use ELF) we can't apply weak linkage
should be done i guess |
also, does this automatically get picked up in every nightly release once merged, or is there a separate PR required for that? |
I need to publish a new version of the crate (I want to get #474 merged first), and then a PR is needed in rust-lang/rust to update the crate version in Cargo.lock. |
I've published version 0.1.77. |
Closes #477
I know in the issue Amanieu said that all functions in this crate should probably get weak linkage when possible, but that seems overkill for my own needs and i didn't want to have to determine when the target will use ELF or not for a lot of functions i'd never heard of.