use #[naked] as an unsafe attribute #817
Open
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible for rustc to accept both forms until this gets updated, to bootstrap this? Unfortunately I don't know if we could merge and release this with the failures here. Another case where a subtree would be nice... Edit: I see rust-lang/rust#139797 now |
|
Right, yeah not ideal but we'll make it work. This PR will then likely needs some |
|
Allright, this works now that rust-lang/rust#139797 is in nightly. After merging this, I guess the next step is to create a release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per rust-lang/rust#134213 (comment), we want to make the
#[naked]attribute an unsafe attribute.Based on the CI failures here rust-lang/rust#139753, I believe that
compiler-builtinsneed to be updated first.