This repository was archived by the owner on May 21, 2019. It is now read-only.
Fix preprocessor directive for non-targeted platforms #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C preprocessor treats undefined identifiers in `#if` expressions as `0` except for `true` and `false`, so the additional expression for Linux-style MIPS ABIs actually turned to `0 == 0` for all other platforms where `_MIPS_SIM` is not defined. Fix that by explicitly checking for `_MIPS_SIM`'s presence.
xen0n
force-pushed
the
preprocessor-firefighting
branch
from
a18521d to
c23f749
Compare
5 tasks
TimNN
pushed a commit
that referenced
this pull request
Apr 23, 2017
Fix preprocessor directive for non-targeted platforms
TimNN
added a commit
that referenced
this pull request
Jul 20, 2017
Fix preprocessor directive for non-targeted platforms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C preprocessor treats undefined identifiers in
#ifexpressionsas
0except fortrueandfalse, so the additional expression forLinux-style MIPS ABIs actually turned to
0 == 0for all other platformswhere
_MIPS_SIMis not defined. Fix that by explicitly checking for_MIPS_SIM's presence.