Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise link-self-contained option #343

Closed
1 of 3 tasks
mati865 opened this issue Aug 12, 2020 · 2 comments
Closed
1 of 3 tasks

Stabilise link-self-contained option #343

mati865 opened this issue Aug 12, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@mati865
Copy link
Contributor

mati865 commented Aug 12, 2020

Proposal

Continuation of #310

Short summary on how this option works on supported targets (windows-gnu, linux-musl, wasi):

  • no value: rustc will use heuristic to disable self-contained mode if system has necessary tools.
  • y, yes, on: use only libraries/objects shipped with Rust.
  • n, no, or off: rely on the user or external linker to provide non-Rust libraries/objects.

Mentors or Reviewers

@petrochenkov made the design here: rust-lang/rust#68887 (comment)

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@mati865 mati865 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Aug 12, 2020
@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 12, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Aug 12, 2020
@mati865 mati865 mentioned this issue Aug 13, 2020
Merged
@petrochenkov
Copy link

@rustbot second
Feels a bit like seconding myself, but anyway.

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Aug 15, 2020
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Aug 26, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 26, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Aug 26, 2020
@mati865 mati865 mentioned this issue Aug 31, 2020
Merged
tmandry added a commit to tmandry/rust that referenced this issue Sep 2, 2020
@tmandry
Rollup merge of rust-lang#76158 - mati865:self-contained-option, r=pe…
4a6aa35 
…trochenkov

Stabilise link-self-contained option

MCP has been accepted: rust-lang/compiler-team#343

I'll add improved heuristic in next PR.
@greenhat616 greenhat616 mentioned this issue Jan 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @mati865 @petrochenkov @rustbot