Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rustc_ty #387

Closed
2 of 3 tasks
LeSeulArtichaut opened this issue Nov 18, 2020 · 2 comments
Closed
2 of 3 tasks

Rename rustc_ty #387

LeSeulArtichaut opened this issue Nov 18, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Nov 18, 2020 •
edited
Loading

Proposal

Rename the rustc_ty crate to be able to use the rustc_ty name for the work-in-progress extraction of the type library from rustc_middle (as part of rust-lang/types-team#16).

Mentors or Reviewers

@nikomatsakis? also cc @jackh726

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@LeSeulArtichaut LeSeulArtichaut added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Nov 18, 2020
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 18, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 19, 2020
@jonas-schievink
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Nov 19, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Nov 19, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#79212 - LeSeulArtichaut:rustc-ty, r=jonas-s…
95da425 
…chievink

Move `rustc_ty` -> `rustc_ty_utils`

Implements MCP rust-lang/compiler-team#387.
r? `@jonas-schievink`
@LeSeulArtichaut LeSeulArtichaut added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @jonas-schievink @LeSeulArtichaut @rustbot