Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[alias] attribute to allow symbol aliasing #526

Closed
1 of 3 tasks
carbotaniuman opened this issue Jul 12, 2022 · 2 comments
Closed
1 of 3 tasks

Add #[alias] attribute to allow symbol aliasing #526

carbotaniuman opened this issue Jul 12, 2022 · 2 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@carbotaniuman
Copy link

carbotaniuman commented Jul 12, 2022

Proposal

ELF platforms along with Windows allow specifying aliases for symbols (I am unsure about Mac). The semantics of aliases are that is simply another name to the same symbol, with no extra layers of indirection, and is available in C as a GCC extension:
int __attribute__((weak, alias("__read"))) read();.

The attribute is similar to the #[linkage] attribute, in that is not designed to be exposed stably, but portions of it may be stabilized depending on use-cases. The syntax would be as follows, applied to an existing function declaration or static, and accepted values for linkage would be external and weak.

The attribute can be repeated to allow for multiple aliases, but each name field must be globally unique to avoid duplicate symbol definitions.

#[alias(name = "read_from_a_thingie")] // should imply `linkage = "external"`
#[alias(name = "read", linkage = "weak")]
#[no_mangle]
extern "C" fn __read() {
...
}

The main use-case for this feature would be current work on Mustang, a libc implemented in Rust, which unfortunately requires a lot of platform-specific shenanigans. This would "properly" fix rust-lang/compiler-builtins#70, although that appears to already have a working workaround.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@carbotaniuman carbotaniuman added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jul 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 12, 2022
@carbotaniuman carbotaniuman changed the title Add #[alias] attribute to allow aliasing statics / functions Add #[alias] attribute to allow symbol aliasing Jul 12, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 21, 2022
@apiraino
Copy link
Contributor

Closing MCP (reason: superseded by a T-lang initiative, as mentioned on the Zulip stream), see MCP process for closing MCPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants