Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64-unknown-openbsd tier-3 support #552

Closed
9 of 11 tasks
semarie opened this issue Aug 26, 2022 · 1 comment
Closed
9 of 11 tasks

riscv64-unknown-openbsd tier-3 support #552

semarie opened this issue Aug 26, 2022 · 1 comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@semarie
Copy link

semarie commented Aug 26, 2022

Proposal

I would add riscv64-unknown-openbsd support to rustc as tier 3 target.

Tier 3 target policy

  • must have a designated developer
    • I am already designated developer for OpenBSD and intent to take this one too
  • must use naming consistent with any existing targets
    • riscv64-unknown-openbsd follows naming at OpenBSD and naming for LLVM triple
  • must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users
  • neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party
  • should attempt to implement as much of the standard libraries as possible and appropriate
    • the implementation is as complete as others OpenBSD targets (std and host are natively compiled)
  • must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible
    • native compilation works out-of-box
  • must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target
  • Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target

Mentors or Reviewers

I am already designated developer for OpenBSD targets.

The implementation is already done and used in OpenBSD ports infrastructure.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@semarie semarie added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Aug 26, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 26, 2022
@semarie semarie changed the title riscv64-unknown-openbsd riscv64-unknown-openbsd tier-3 support Aug 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2022
Add tier-3 support for powerpc64 and riscv64 openbsd

# powerpc64
- MCP for [powerpc64-unknown-openbsd tier-3 support](rust-lang/compiler-team#551)
- only need to add spec definition in rustc_target

# riscv64
- MCP for [riscv64-unknown-openbsd tier-3 support](rust-lang/compiler-team#552)
- add spec definition in rustc_target
- follow freebsd about avoiding linking with `libatomic`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 31, 2022
Add tier-3 support for powerpc64 and riscv64 openbsd

# powerpc64
- MCP for [powerpc64-unknown-openbsd tier-3 support](rust-lang/compiler-team#551)
- only need to add spec definition in rustc_target

# riscv64
- MCP for [riscv64-unknown-openbsd tier-3 support](rust-lang/compiler-team#552)
- add spec definition in rustc_target
- follow freebsd about avoiding linking with `libatomic`
@semarie semarie closed this as completed Aug 31, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants