Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match the behavior of strip and split-debuginfo across platforms #669

Closed
1 of 3 tasks
icedrocket opened this issue Aug 28, 2023 · 2 comments
Closed
1 of 3 tasks

Match the behavior of strip and split-debuginfo across platforms #669

icedrocket opened this issue Aug 28, 2023 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@icedrocket
Copy link

icedrocket commented Aug 28, 2023 •
edited
Loading

Proposal

Currently, strip and split-debuginfo behave similarly on all platforms except MSVC. The reason why the two options behave so differently on MSVC is because they were added without consideration for each other. I'm proposing here to make the setup easier to understand and simpler.

Unify strip to strip debug information from the executable only (so that MSVC ignores this option), and change split-debuginfo to determine whether MSVC creates a PDB file.

This is necessary to improve cross-platform behavior consistency: if someone wanted debug information to be contained only in separate files on all platforms, they would set strip=symbols and split-debuginfo=packed, but this would result in no PDB files on MSVC.

rust-lang/rust#114215
rust-lang/rust#115120

Mentors or Reviewers

Reviewable by any compiler team member or compiler contributor.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@icedrocket icedrocket added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Aug 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 28, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 1, 2023
@pnkfelix
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 24, 2023
@apiraino apiraino added the major-change-accepted A major change proposal that was accepted label Dec 14, 2023
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Dec 14, 2023
@apiraino apiraino removed final-comment-period The FCP has started, most (if not all) team members are in agreement to-announce Announce this issue on triage meeting labels Dec 14, 2023
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pnkfelix @apiraino @rustbot @icedrocket