Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the run-pass-valgrind test suite #792

Closed
1 of 3 tasks
jieyouxu opened this issue Oct 7, 2024 · 5 comments
Closed
1 of 3 tasks

Remove the run-pass-valgrind test suite #792

jieyouxu opened this issue Oct 7, 2024 · 5 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 7, 2024

Proposal

Remove the run-pass-valgrind test suite. This test suite is not properly hooked up to bootstrap, and run-pass-valgrind tests don't actually get exercised under valgrind. See https://github.com/rust-lang/rust/blob/1b3b8e7b0265162853c650ead09905bc3cdaeae9/src/tools/compiletest/src/runtest/valgrind.rs#L7-L12. Providing valgrind paths was not hooked up to bootstrap and our CI jobs don't run it. opt-dist currently run the run-pass-valgrind tests but because it's not properly hooked up in bootstrap, they are just naive run-pass tests.

Mentors or Reviewers

Bootstrap reviewers (@Kobzol who is already reviewing the rust-lang/rust#131351 PR).

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@jieyouxu jieyouxu added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Oct 7, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@Urgau
Copy link
Member

Urgau commented Oct 7, 2024

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 7, 2024
@Noratrieb
Copy link
Member

i feel like an MCP is overkill for something like this. tests that don't work and don't run are obviously bad!
(don't wait for the 10 days, just merge)

@apiraino
Copy link
Contributor

apiraino commented Oct 7, 2024

As I said on Zulip, I agree but I felt that an MCP could be useful to let everyone know

@apiraino
Copy link
Contributor

apiraino commented Oct 7, 2024

anyway

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Oct 7, 2024
@rustbot rustbot added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 7, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

5 participants