-
Notifications
You must be signed in to change notification settings - Fork 71
Remove the run-pass-valgrind
test suite
#792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
Concerns can be lifted with:
See documentation at https://forge.rust-lang.org cc @rust-lang/compiler @rust-lang/compiler-contributors |
@rustbot second |
i feel like an MCP is overkill for something like this. tests that don't work and don't run are obviously bad! |
As I said on Zulip, I agree but I felt that an MCP could be useful to let everyone know |
anyway @rustbot label -final-comment-period +major-change-accepted |
Proposal
Remove the
run-pass-valgrind
test suite. This test suite is not properly hooked up to bootstrap, andrun-pass-valgrind
tests don't actually get exercised under valgrind. See https://github.com/rust-lang/rust/blob/1b3b8e7b0265162853c650ead09905bc3cdaeae9/src/tools/compiletest/src/runtest/valgrind.rs#L7-L12. Providing valgrind paths was not hooked up to bootstrap and our CI jobs don't run it.opt-dist
currently run therun-pass-valgrind
tests but because it's not properly hooked up in bootstrap, they are just naiverun-pass
tests.Mentors or Reviewers
Bootstrap reviewers (@Kobzol who is already reviewing the rust-lang/rust#131351 PR).
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: