Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the baseline Solaris version to 11.4 #812

Closed
1 of 3 tasks
tgross35 opened this issue Dec 3, 2024 · 3 comments
Closed
1 of 3 tasks

Set the baseline Solaris version to 11.4 #812

tgross35 opened this issue Dec 3, 2024 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@tgross35
Copy link

tgross35 commented Dec 3, 2024

Proposal

Currently there is no documented minimum Solaris version. @psumbera (who has been the de facto target maintainer for a long time) put up a PR that documents the minimum version as 11.4, which was released 2018-08 rust-lang/rust#133293: rust-lang/rust#133293.

This means we will no longer support versions 10 (released 2005-01) or 11.3 (released 2015-10), both of which are still supported until January 2027, so this MCP's goal is mostly to give an objection period in case anyone relies on this. The change seems reasonable, especially considering it doesn't seem like we know that builds for older versions are working today.

Some background discussion at https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Solaris.20baseline

Mentors or Reviewers

N/A

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@tgross35 tgross35 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Dec 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@jieyouxu
Copy link
Member

jieyouxu commented Dec 3, 2024

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Dec 3, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 5, 2024
@tgross35
Copy link
Author

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Dec 14, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants