-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a repository for cargo-lockfile-sync #89
Conversation
@rfcbot pr merge I propose we start out of tree immediately instead of pulling it out of tree later. Thus, this project starts out with no code, just an empty project with licenses and a README. The code already exists, but can only be added to an existing project by the author (see linked issue for details). |
Team member @oli-obk has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
It seems like this tool wouldn't fall under the compiler team. |
Why is updating versions in I assumed that they are supposed to be coarse-grained like |
The original problem was that there are PRs that update just the lockfile, which seemed wrong to me. One example is rust-lang/rust#57435 where a version bump was necessary, but not reflected in the
Is this more infra then? |
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @oli-obk, I wasn't able to add the |
I forgot to mention that |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. psst @oli-obk, I wasn't able to add the |
Come to think more of it, this seems perfectly fine for the |
Originally suggested in rust-lang/rust#57443
This project is a custom crate that is independent of rustc, but will keep our
toml
files in sync with thelock
files (rationale, see linked issue). Instead of putting that code in-tree, I want it to start out of tree immediately, since it's generally useful.