Rules for const safety and promotion #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I significantly expanded the discussion of promotion, also covering the concerns raised in #2. |
oli-obk
requested changes
Aug 30, 2018
const_safety.md
Outdated
| pointer). | ||
| * The program panics (e.g., a failed bounds check). | ||
| * The program loops forever, and this is detected by the loop detector. |
There was a problem hiding this comment.
On a best effort basis. We basically don't care too much about nontermination except for diagnostics
There was a problem hiding this comment.
AFAIK we do error hard if we detect a reoccurring state? This could happen in a promoted as well.
|
Note that while the |
oli-obk
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my blog posts and lots of prior discussion with @oli-obk and @eddyb. I am sure I forgot some of that discussion though, so please let me know what is wrong or missing.^^