Auto merge of #2901 - Turbo87:yarn, r=jtgeibel

Switch from npm to yarn

As discussed in the meeting on friday, yarn currently has better UX and allows us to use `resolutions` to work around transitive dependency version conflicts. This should unblock #2699, for example.

r? `@jtgeibel`

Author: bors

.github/workflows/ci.yml

@@ -24,33 +24,26 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - uses: actions/cache@v2
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-
       - uses: actions/setup-node@v1
         with:
-          node-version: '12.x'
+          node-version: '14.x'
 
       - name: Install node modules
-        run: npm ci
+        run: yarn install
 
       - name: Lint
         run: |
-          npm run lint:hbs
-          npm run lint:js
-          npm run lint:deps
+          yarn lint:hbs
+          yarn lint:js
+          yarn lint:deps
 
       - name: Run percy exec
         if: github.repository == 'rust-lang/crates.io'
         run: npx percy exec -- npm run test-coverage
 
       - name: test-coverage
         if: github.repository != 'rust-lang/crates.io'
-        run: npm run test-coverage
+        run: yarn test-coverage
 
   backend:
     name: Backend

.travis.yml

@@ -10,8 +10,8 @@ branches:
 
 cache:
   cargo: true
-  directories:
-    - $HOME/.npm
+  yarn: true
+
 before_cache: script/ci/prune-cache.sh
 
 env:
@@ -59,17 +59,17 @@ jobs:
         - cargo test
     - name: Frontend
       language: node_js
-      node_js: 12
+      node_js: 14
       addons:
         chrome: stable
       install:
-        - npm ci
+        - yarn install
       before_script: skip
       script:
-        - npm run lint:hbs
-        - npm run lint:js
-        - npm run lint:deps
-        - if [ "$TRAVIS_REPO_SLUG" == "rust-lang/crates.io" ]; then percy exec -- npm run test-coverage; fi
+        - yarn lint:hbs
+        - yarn lint:js
+        - yarn lint:deps
+        - if [ "$TRAVIS_REPO_SLUG" == "rust-lang/crates.io" ]; then percy exec -- yarn test-coverage; fi
     - rust: beta
       script:
         - cargo test

docker-compose.yml

@@ -36,7 +36,7 @@ services:
     build:
       context: .
       dockerfile: frontend.Dockerfile
-    entrypoint: npm run start -- --proxy http://backend:8888
+    entrypoint: yarn start -- --proxy http://backend:8888
     links:
       - backend
     ports:

docs/CONTRIBUTING.md

@@ -88,7 +88,7 @@ as well.
 In order to run the frontend on Windows and macOS, you will need to have installed:
 
 - [node](https://nodejs.org/en/) >= 12.9.1 (see `package.json` and `.github/workflows/ci.yml` for what we currently use)
-- [npm](https://www.npmjs.com/get-npm) >= 6.10.2
+- [yarn](https://classic.yarnpkg.com/en/docs/install) v1.x
 
 Follow the links for each of these tools for their recommended installation
 instructions. If you already have these tools, or you have a different
@@ -105,25 +105,25 @@ into any trouble.
 To install the npm packages that crates.io uses, run:
 
 ```
-npm install
+yarn install
 ```
 
 You'll need to run these commands any time the libraries or versions of these
 libraries that crates.io uses change. Usually you'll know they've changed
 because you'll run the next step and it will fail saying it can't find some
 libraries.
 
-To build and serve the frontend assets, use the command `npm run start`. There
+To build and serve the frontend assets, use the command `yarn start`. There
 are variations on this command that change which backend your frontend tries to
 talk to:
 
 | Command | Backend | Use case |
 |---------|---------|----------|
-| `npm run start:live` | https://crates.io | Testing UI changes with the full live site's data |
-| `npm run start:staging` | https://staging-crates-io.herokuapp.com | Testing UI changes with a smaller set of realistic data |
-| `npm run start` | Static fixture test data in `mirage/fixtures` | Setting up particular situations, see note |
-| `npm run start:local` | Backend server running locally | See the Working on the backend section for setup |
-| `npm run start -- --proxy https://crates.io` | Whatever is specified in `--proxy` arg | If your use case is not covered here |
+| `yarn start:live` | https://crates.io | Testing UI changes with the full live site's data |
+| `yarn start:staging` | https://staging-crates-io.herokuapp.com | Testing UI changes with a smaller set of realistic data |
+| `yarn start` | Static fixture test data in `mirage/fixtures` | Setting up particular situations, see note |
+| `yarn start:local` | Backend server running locally | See the Working on the backend section for setup |
+| `yarn start -- --proxy https://crates.io` | Whatever is specified in `--proxy` arg | If your use case is not covered here |
 
 > Note: If you want to set up a particular situation, you can edit the fixture
 > data used for tests in `mirage/fixtures`. The fixture data does not currently
@@ -135,7 +135,7 @@ talk to:
 You can run the frontend tests with:
 
 ```
-npm test
+yarn test
 ```
 
 ### Working on the Backend
@@ -362,7 +362,7 @@ without a restart needed, and you can leave the frontend running while you
 restart the server):
 
 ```
-npm run start:local
+yarn start:local
 ```
 
 And then you should be able to visit http://localhost:4200!

frontend.Dockerfile

@@ -1,10 +1,10 @@
 FROM node:12.9-alpine
 
 WORKDIR /app
-COPY package.json package-lock.json /app/
+COPY package.json yarn.lock /app/
 
-RUN npm install
+RUN yarn install
 
 COPY . /app
 
-ENTRYPOINT ["npm", "run", "start:staging"]
+ENTRYPOINT ["yarn", "start:staging"]