Update dependency ember-router-scroll to v3 #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 2 commits into master from renovate/ember-router-scroll-3.x

Oct 17, 2020

Contributor

renovate bot commented Aug 16, 2020 •

edited

Loading

This PR contains the following updates:

Package	Type	Update	Change
ember-router-scroll	devDependencies	major	`2.0.2` -> `3.3.3`

Release Notes

dockyard/ember-router-scroll

`v3.3.3`

`v3.3.2`

`v3.3.1`

`v3.3.0`

#246 Add Evented trigger didScroll

`v3.2.0`

#244 Bring back scroll recursive

`v3.1.3`

#242 Unique functions to scheduleOnce...follow up
#241 Prevent multiple calls on routeDidChange
#240 Missing setter for scrollWhenAfterRender

`v3.1.2`

`v3.1.1`

`v3.1.0`

#239 Scroll when afterRender

`v3.0.0`

#238 Upgrade ember-app-scheduler to v4.0.0

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

rust-highfive assigned smarnach

rust-highfive commented Aug 16, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive added the S-waiting-on-review label

Contributor

bors commented Aug 16, 2020

☔ The latest upstream changes (presumably #2697) made this pull request unmergeable. Please resolve the merge conflicts.

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from 37b1581 to b915ece Compare

August 16, 2020 18:05

Contributor

bors commented Aug 19, 2020

☔ The latest upstream changes (presumably #2701) made this pull request unmergeable. Please resolve the merge conflicts.

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from b915ece to 8926e64 Compare

August 19, 2020 07:57

Contributor

bors commented Aug 24, 2020

☔ The latest upstream changes (presumably #2712) made this pull request unmergeable. Please resolve the merge conflicts.

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from 8926e64 to 26b9aac Compare

August 24, 2020 22:46

Contributor

bors commented Aug 29, 2020

☔ The latest upstream changes (presumably #2726) made this pull request unmergeable. Please resolve the merge conflicts.

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from 26b9aac to d43e411 Compare

August 29, 2020 15:59

Contributor

bors commented Sep 1, 2020

☔ The latest upstream changes (presumably #2738) made this pull request unmergeable. Please resolve the merge conflicts.

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from d43e411 to fe6cdca Compare

September 1, 2020 02:01

Contributor

bors commented Sep 7, 2020

☔ The latest upstream changes (presumably #2755) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from fe6cdca to 010f920 Compare

September 7, 2020 22:15

Contributor

bors commented Sep 8, 2020

☔ The latest upstream changes (presumably #2691) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from 010f920 to c54e869 Compare

September 8, 2020 23:54

Contributor

bors commented Sep 27, 2020

☔ The latest upstream changes (presumably #2713) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from c54e869 to f95b960 Compare

September 27, 2020 14:59

Contributor

bors commented Sep 30, 2020

☔ The latest upstream changes (presumably #2849) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from f95b960 to 400b163 Compare

September 30, 2020 18:19

Contributor

bors commented Sep 30, 2020

☔ The latest upstream changes (presumably #2852) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch 2 times, most recently from 53190b5 to 7bb0c97 Compare

October 6, 2020 15:19

Turbo87 mentioned this pull request

Switch from npm to yarn #2901

Merged

bors added a commit that referenced this pull request


          Auto merge of #2901 - Turbo87:yarn, r=jtgeibel

Switch from npm to yarn

As discussed in the meeting on friday, yarn currently has better UX and allows us to use `resolutions` to work around transitive dependency version conflicts. This should unblock #2699, for example.

r? `@jtgeibel`

Contributor

bors commented Oct 16, 2020

☔ The latest upstream changes (presumably #2901) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

renovate bot force-pushed the renovate/ember-router-scroll-3.x branch from 7bb0c97 to a0ade62 Compare

October 16, 2020 13:35

Contributor

bors commented Oct 17, 2020

☔ The latest upstream changes (presumably #2914) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Turbo87 force-pushed the renovate/ember-router-scroll-3.x branch from a0ade62 to 7c31691 Compare

October 17, 2020 13:36

renovate-bot and others added 2 commits

October 17, 2020 15:36


          Update dependency ember-router-scroll to v3

56e6352


          package.json: Add ember-test-waiters resolution

ccc6c81

... to resolve the conflict caused by the `ember-app-scheduler` dependency

Turbo87 force-pushed the renovate/ember-router-scroll-3.x branch from 7c31691 to ccc6c81 Compare

October 17, 2020 13:36

Member

Turbo87 commented Oct 17, 2020

Contributor

bors commented Oct 17, 2020

📌 Commit ccc6c81 has been approved by Turbo87

Contributor

bors commented Oct 17, 2020

⌛ Testing commit ccc6c81 with merge 85e95ff...

Contributor

bors commented Oct 17, 2020

☀️ Test successful - checks-travis
Approved by: Turbo87
Pushing 85e95ff to master...

bors merged commit 85e95ff into master

bors mentioned this pull request

Pin dependencies #2918

Merged

1 task

renovate bot deleted the renovate/ember-router-scroll-3.x branch

October 17, 2020 13:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet