Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2020

This PR contains the following updates:

Package Type Update Change
ember-set-body-class devDependencies pin ^1.0.1 -> 1.0.1
ember-test-waiters resolutions pin ^2.0.0 -> 2.1.3

📌 Important: Renovate will wait until you have merged this Pin PR before creating any upgrade PRs for the affected packages. Add the preset :preserveSemverRanges to your config if you instead don't wish to pin dependencies.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Turbo87 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87
Copy link
Member

Turbo87 commented Oct 17, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2020

📌 Commit 4de0805 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Oct 17, 2020

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout renovate/pin-dependencies (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self renovate/pin-dependencies --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging yarn.lock
Auto-merging package.json
CONFLICT (content): Merge conflict in package.json
Automatic merge failed; fix conflicts and then commit the result.

@bors
Copy link
Contributor

bors commented Oct 17, 2020

☔ The latest upstream changes (presumably #2699) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@renovate renovate bot force-pushed the renovate/pin-dependencies branch from 4de0805 to b12705d Compare October 17, 2020 13:59
@renovate renovate bot changed the title Pin dependency ember-set-body-class to 1.0.1 Pin dependencies Oct 17, 2020
@Turbo87
Copy link
Member

Turbo87 commented Oct 17, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2020

📌 Commit b12705d has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Oct 17, 2020

⌛ Testing commit b12705d with merge e4b4ec6...

@bors
Copy link
Contributor

bors commented Oct 17, 2020

☀️ Test successful - checks-travis
Approved by: Turbo87
Pushing e4b4ec6 to master...

@bors bors merged commit e4b4ec6 into master Oct 17, 2020
@renovate renovate bot deleted the renovate/pin-dependencies branch October 17, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants