Skip to content

shields.io badge shows prerelease version; should show latest stable version #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sophiajt opened this issue Feb 15, 2018 · 6 comments
Closed
Labels
C-bug 🐞 Category: unintended, undesired behavior

Comments

@sophiajt
Copy link

The CSV package (https://crates.io/crates/csv) currently shows both of these at the same time:

screen shot 2018-02-16 at 6 23 48 am

screen shot 2018-02-16 at 6 23 54 am

It seems the beta thing may be confusing crates.io to not show the correct Cargo.toml line? I'm not sure, but figured it was worth mentioning.

@sgrif
Copy link
Contributor

sgrif commented May 3, 2018

There's an argument for either the badge or the Cargo.toml line being correct. We should probably decide whether we want to ever consider pre-release versions to be the "latest" version or not.

@carols10cents
Copy link
Member

We decided in #577 not to recommend pre-release versions, so the shields.io badge should be changed to match the Cargo.toml snippet.

@carols10cents carols10cents changed the title csv package shows the wrong version number shields.io badge shows prerelease version; should show latest stable version Jun 27, 2018
@carols10cents carols10cents added A-badges C-bug 🐞 Category: unintended, undesired behavior labels Jun 27, 2018
@locks locks self-assigned this Sep 7, 2019
@locks locks removed their assignment Apr 19, 2020
@locks
Copy link
Contributor

locks commented Apr 19, 2020

This is actually a symptom of the problem described in #654, so we will track it there. Thanks for reporting!

@locks locks closed this as completed Apr 19, 2020
@FabijanC
Copy link

FabijanC commented Jul 24, 2024

Isn't this still an issue? E.g. consider this shields.io badge from the URL https://img.shields.io/crates/v/blockifier:
Crates.io Version

And consider these versions:
https://crates.io/crates/blockifier/versions

Shouldn't the badge show 0.5.0?

@Turbo87
Copy link
Member

Turbo87 commented Jul 24, 2024

yes, but that is an issue on the shields.io side. https://crates.io/api/v1/crates/blockifier returns:

max_stable_version: "0.5.0"
max_version: "0.8.0-rc.1"

which shields.io could use to display 0.5.0 instead.

@FabijanC
Copy link

Thanks for pointing this out! I see there is an open issue on their side: badges/shields#8666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

6 participants