-
Notifications
You must be signed in to change notification settings - Fork 641
shields.io badge shows prerelease version; should show latest stable version #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There's an argument for either the badge or the Cargo.toml line being correct. We should probably decide whether we want to ever consider pre-release versions to be the "latest" version or not. |
We decided in #577 not to recommend pre-release versions, so the shields.io badge should be changed to match the Cargo.toml snippet. |
This is actually a symptom of the problem described in #654, so we will track it there. Thanks for reporting! |
Isn't this still an issue? E.g. consider this shields.io badge from the URL https://img.shields.io/crates/v/blockifier: And consider these versions: Shouldn't the badge show 0.5.0? |
yes, but that is an issue on the shields.io side. https://crates.io/api/v1/crates/blockifier returns:
which shields.io could use to display 0.5.0 instead. |
Thanks for pointing this out! I see there is an open issue on their side: badges/shields#8666 |
The CSV package (https://crates.io/crates/csv) currently shows both of these at the same time:
It seems the beta thing may be confusing crates.io to not show the correct Cargo.toml line? I'm not sure, but figured it was worth mentioning.
The text was updated successfully, but these errors were encountered: