Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yanked crates should be discounted/de-emphasized/demarcated somehow in search results #145

Open
daboross opened this issue Apr 17, 2015 · 4 comments
Labels
A-search C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@daboross
Copy link

If all versions of a crate have been yanked, it probably shouldn't show up in searches, at least I can't see why it would want to. If a user clicks on a completely-yanked crate that shows up in search, they will be brought to a page which simply states "This crate has been yanked, but it is still available for download for other crates that may be depending on it.".

It seems like it would be better to not display those crates at all, or maybe add a checkbox with Show deprecated crates to toggle showing them.

For example, https://crates.io/search?q=fern brings up the now-useless fern_macros crate (which has been completely yanked, and doesn't compile on the beta), instead of just the fern crate.

@carols10cents
Copy link
Member

Hm, what if you're searching to see if a name is taken yet? You're still not allowed to use the name of a crate that has had all its versions yanked.

The Show deprecated crates checkbox is a good idea, I'd want it to be checked by default though and saved in a cookie (as opposed to saving it with your user account, so that you don't have to be logged in to save your preference) and I don't think we have anything stored in cookies right now so this wouldn't be super trivial.

Other options:

  • show a badge, or possibly show 'yanked' in the badge where the latest version number is now
  • fade a crate in a list when all its versions have been yanked
  • sort yanked crates to the bottom, unless it's an exact name match for your query (those get ranked at the top right now)

@daboross
Copy link
Author

daboross commented Feb 21, 2017

Thank you for the response!

I think a "yanked" badge would definitely be better than what we have now, and could work well alongside a 'Show deprecated crates' checkbox, if that was implemented later.

I don't know or have any preference on what should be done with crates where some versions are yanked - I'm just concerned that crates that aren't at all for new projects to use are showing up as if they were available crates.

@carols10cents carols10cents changed the title Yanked crates shouldn't show up in searches Yanked crates should be discounted somehow in search results Aug 2, 2017
@carols10cents carols10cents changed the title Yanked crates should be discounted somehow in search results Yanked crates should be discounted/de-emphasized/demarcated somehow in search results Aug 2, 2017
@carols10cents carols10cents added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Aug 2, 2017
@ghost
Copy link

ghost commented Aug 13, 2017

I think they should disappear from user pages

@carols10cents
Copy link
Member

@fwrs thanks for the suggestion! I've filed #958 for that.

bors added a commit that referenced this issue Dec 17, 2019
…1.1.0, r=locks

Bump @ember/jquery from 0.6.1 to 1.1.0

Bumps [@ember/jquery](https://github.com/emberjs/ember-jquery) from 0.6.1 to 1.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [@ember/jquery's releases](https://github.com/emberjs/ember-jquery/releases).*

> ## Release 1.1.0
> #### 🚀 Enhancement
> * [#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/153) Add missing deprecation message for `this.$()` ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 3
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
>
> ## Release 1.0.0
> #### 💥 Breaking Change
> * [#100](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/100) ember-cli-update to 3.10, drop node 6 ([@&#8203;simonihmig](https://github.com/simonihmig))
>
> #### 🚀 Enhancement
> * [#148](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/148) Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. ([@&#8203;lupestro](https://github.com/lupestro))
>
> #### 📝 Documentation
> * [#145](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/145) Add directions to import and use jQuery ([@&#8203;jrjohnson](https://github.com/jrjohnson))
>
> #### Committers: 4
> - Jonathan Johnson ([@&#8203;jrjohnson](https://github.com/jrjohnson))
> - Ralph Mack ([@&#8203;lupestro](https://github.com/lupestro))
> - Simon Ihmig ([@&#8203;simonihmig](https://github.com/simonihmig))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [@ember/jquery's changelog](https://github.com/emberjs/ember-jquery/blob/master/CHANGELOG.md).*

> ## v1.1.0 (2019-10-04)
>
> #### 🚀 Enhancement
> * [#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/153) Add missing deprecation message for `this.$()` ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 3
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
>
> ## v1.0.0 (2019-10-02)
>
> #### 💥 Breaking Change
> * [#100](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/100) ember-cli-update to 3.10, drop node 6 ([@&#8203;simonihmig](https://github.com/simonihmig))
>
> #### 🚀 Enhancement
> * [#148](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/148) Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. ([@&#8203;lupestro](https://github.com/lupestro))
>
> #### 📝 Documentation
> * [#145](https://github-redirect.dependabot.com/emberjs/ember-jquery/pull/145) Add directions to import and use jQuery ([@&#8203;jrjohnson](https://github.com/jrjohnson))
>
> #### Committers: 4
> - Jonathan Johnson ([@&#8203;jrjohnson](https://github.com/jrjohnson))
> - Ralph Mack ([@&#8203;lupestro](https://github.com/lupestro))
> - Simon Ihmig ([@&#8203;simonihmig](https://github.com/simonihmig))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
</details>
<details>
<summary>Commits</summary>

- [`9112702`](emberjs/ember-jquery@9112702) Release 1.1.0
- [`c88dbf1`](emberjs/ember-jquery@c88dbf1) Add missing deprecation message for `this.$()` ([#153](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/153))
- [`dd96dd5`](emberjs/ember-jquery@dd96dd5) Remove `noDeprecations` tests
- [`cade173`](emberjs/ember-jquery@cade173) Add missing deprecation message for `this.$()`
- [`52886ad`](emberjs/ember-jquery@52886ad) Merge pull request [#152](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/152) from emberjs/dependabot/npm_and_yarn/ember-cli-htmlba...
- [`7a533b7`](emberjs/ember-jquery@7a533b7) Bump ember-cli-htmlbars from 4.0.3 to 4.0.4
- [`32d79c3`](emberjs/ember-jquery@32d79c3) Re-roll yarn.lock to avoid issues with missing integrity in yarn… ([#151](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/151))
- [`4969158`](emberjs/ember-jquery@4969158) Re-roll yarn.lock to avoid issues with missing integrity in yarn 1.19.0
- [`0a6391d`](emberjs/ember-jquery@0a6391d) Bump eslint-plugin-node from 9.2.0 to 10.0.0 ([#133](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/133))
- [`07d66b4`](emberjs/ember-jquery@07d66b4) Merge pull request [#138](https://github-redirect.dependabot.com/emberjs/ember-jquery/issues/138) from emberjs/dependabot/npm_and_yarn/ember/optional-f...
- Additional commits viewable in [compare view](emberjs/ember-jquery@v0.6.1...v1.1.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=@ember/jquery&package-manager=npm_and_yarn&previous-version=0.6.1&new-version=1.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=@ember/jquery&package-manager=npm_and_yarn&previous-version=0.6.1&new-version=1.1.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
bors added a commit that referenced this issue Dec 18, 2019
….6.0, r=locks

Bump ember-percy from 1.4.0 to 1.6.0

Bumps [ember-percy](https://github.com/percy/ember-percy) from 1.4.0 to 1.6.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-percy's releases](https://github.com/percy/ember-percy/releases).*

> ## v1.6.0
> ## What changed?
>
> This version of ember-percy includes more from input serialization when taking the DOM snapshot. You should now see all form inputs properly capture their state ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
>
> ## v1.5.0
> Bower was removed - [#73](https://github-redirect.dependabot.com/percy/ember-percy/issues/73)     🎉 🌮 🎉 🗡
> Node 4 was removed from testing - [#75](https://github-redirect.dependabot.com/percy/ember-percy/issues/75) & [#74](https://github-redirect.dependabot.com/percy/ember-percy/issues/74)
> PERCY_PROJECT environment variable is no longer required - [#72](https://github-redirect.dependabot.com/percy/ember-percy/issues/72)  🚀
> Some defensive programming was added - [#71](https://github-redirect.dependabot.com/percy/ember-percy/issues/71) (thanks [@&#8203;Gaurav0](https://github.com/Gaurav0)!) 🛡
>
> ## v1.4.4
> **Important bugfix, please upgrade:**
> - Fix duplicate asset clobbering resource paths. ([#70](https://github-redirect.dependabot.com/percy/ember-percy/issues/70))
>
> ## v1.4.3
> Do not release yarn.lock to npm. Thanks [@&#8203;Turbo87](https://github.com/Turbo87)!
>
> ## v1.4.2
> Fix jQuery version conflict bug. ([#65](https://github-redirect.dependabot.com/percy/ember-percy/issues/65))
>
> ## v1.4.1
> 🐛 Reintroduce support for older ember apps that don't know about `@ember/test` yet.
</details>
<details>
<summary>Commits</summary>

- [`dd7288c`](percy/percy-ember@dd7288c) v1.6.0
- [`a31d5b4`](percy/percy-ember@a31d5b4) feat: Add more form element serialization  ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
- [`e387464`](percy/percy-ember@e387464) build(deps): Bump handlebars from 4.0.11 to 4.2.0 ([#145](https://github-redirect.dependabot.com/percy/ember-percy/issues/145))
- [`868783a`](percy/percy-ember@868783a) build(deps): Bump underscore.string from 3.3.4 to 3.3.5 ([#144](https://github-redirect.dependabot.com/percy/ember-percy/issues/144))
- [`8442380`](percy/percy-ember@8442380) build(deps-dev): Bump ember-cli-htmlbars-inline-precompile ([#140](https://github-redirect.dependabot.com/percy/ember-percy/issues/140))
- [`9f503a7`](percy/percy-ember@9f503a7) build(deps-dev): Bump eslint-plugin-node from 9.1.0 to 9.2.0 ([#143](https://github-redirect.dependabot.com/percy/ember-percy/issues/143))
- [`d0786ac`](percy/percy-ember@d0786ac) build(deps): Bump percy-client from 3.0.12 to 3.0.13 ([#142](https://github-redirect.dependabot.com/percy/ember-percy/issues/142))
- [`29877a5`](percy/percy-ember@29877a5) build(deps): Bump ember-cli-babel from 7.10.0 to 7.11.0 ([#141](https://github-redirect.dependabot.com/percy/ember-percy/issues/141))
- [`0109d54`](percy/percy-ember@0109d54) build(deps-dev): Bump ember-load-initializers from 2.0.0 to 2.1.0 ([#139](https://github-redirect.dependabot.com/percy/ember-percy/issues/139))
- [`e8c6f35`](percy/percy-ember@e8c6f35) build(deps): [Security] Bump mixin-deep from 1.3.1 to 1.3.2 ([#138](https://github-redirect.dependabot.com/percy/ember-percy/issues/138))
- Additional commits viewable in [compare view](percy/percy-ember@v1.4.0...v1.6.0)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [percy-admin](https://www.npmjs.com/~percy-admin), a new releaser for ember-percy since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
@Turbo87 Turbo87 removed the A-yank label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-search C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

4 participants