Skip to content

Exclude yanked version on getting currentVersion #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunng87 opened this issue Mar 20, 2019 · 0 comments
Closed

Exclude yanked version on getting currentVersion #1683

sunng87 opened this issue Mar 20, 2019 · 0 comments

Comments

@sunng87
Copy link
Contributor

sunng87 commented Mar 20, 2019 •
edited
Loading

Live case: https://crates.io/crates/handlebars

Handlebars' current version was 2.0.0-beta.1. Its last stable version 1.2.0 was yanked.

Previously crates.io showed 1.1.0 correctly as max version as 1.2.0 yanked. However after 2.0.0-beta.1 released, crates.io picked 1.2.0 as max one and it's said the crate is yanked.

There should be issue with max_version in krates/models.rs

Update: the data returned from backend was correct.
@sunng87 sunng87 changed the title Exclude yanked version on getting max_version Exclude yanked version on getting currentVersion Mar 20, 2019
@sunng87 sunng87 mentioned this issue Mar 21, 2019
Merged
bors added a commit that referenced this issue Mar 21, 2019
@bors
Auto merge of #1684 - sunng87:fix/version-get, r=sgrif
faf625e 
Added check for yanked status when computing currentVersion

Fixes #1683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunng87