Skip to content

Mistakes in 'Build Script' docs #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexreg opened this issue May 11, 2016 · 2 comments · Fixed by rust-lang/cargo#3286
Closed

Mistakes in 'Build Script' docs #336

alexreg opened this issue May 11, 2016 · 2 comments · Fixed by rust-lang/cargo#3286

Comments

@alexreg
Copy link

alexreg commented May 11, 2016

  1. The sentence

Any other element is a user-defined metadata that will be passed to dependencies.

should instead read

Any other element is a user-defined metadata that will be passed to *dependents*.

  1. The sentence

We’ve also seen a brief example of how a build script can use a crate as a dependency purely for the build process and not for the crate itself at runtime.

should appear at the end of the 2nd case study, not the 1st, where it clearly doesn't apply.
@ducks ducks mentioned this issue Nov 12, 2016
Merged
bors added a commit to rust-lang/cargo that referenced this issue Nov 15, 2016
@bors
Auto merge of #3286 - rjgoldsborough:build-script-docs-mistake-336, r…
a9c23dd 
…=alexcrichton

fixing build script docs mistakes

Fixes rust-lang/crates.io#336
@carols10cents
Copy link
Member

It looks like this was fixed in rust-lang/cargo#3286; I'm guessing cross-repo "fixes" doesn't automatically close issues :) Please reopen if I'm mistaken! ❤️

@alexreg
Copy link
Author

alexreg commented Dec 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing build script docs mistakes
2 participants
@alexreg @carols10cents