Skip to content

All series on a given axis must be of the same data type #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtolnay opened this issue Sep 2, 2016 · 7 comments
Closed

All series on a given axis must be of the same data type #431

dtolnay opened this issue Sep 2, 2016 · 7 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented Sep 2, 2016

https://crates.io/crates/serde

selection_008

This worked earlier today.
@dtolnay
Copy link
Member Author

dtolnay commented Sep 2, 2016

Looks like old versions work:

selection_009

But the newest version is a string for some reason:

selection_010

Data column(s) for axis #0 cannot be of type string

@alexcrichton
Copy link
Member

cc @TyOverby

Perhaps related to #426 ?

@dtolnay
Copy link
Member Author

dtolnay commented Sep 2, 2016

Looks like this is caused by google/google-visualization-issues#1487. It should not add empty series to the chart.

@TyOverby
Copy link
Contributor

TyOverby commented Sep 2, 2016

This is a change that was exposed by #426.

I can reproduce.

Working on a fix.

@TyOverby
Copy link
Contributor

TyOverby commented Sep 2, 2016

Reproduction steps:

  • View a crate that has a version which has never been downloaded. Example

@TyOverby
Copy link
Contributor

TyOverby commented Sep 2, 2016 •
edited
Loading

Fix here: #432

I'm working on cleaning up the code though, so don't merge yet.

Fix is ready for review

@SoniEx2
Copy link

SoniEx2 commented Sep 3, 2016

Shouldn't this be closed?

@dtolnay dtolnay closed this as completed Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @TyOverby @SoniEx2 @dtolnay