Skip to content

Redirecting to the latest crate should only use non-yanked versions #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shepmaster opened this issue Jan 20, 2017 · 9 comments
Closed
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@shepmaster
Copy link
Member

Right now, if I visit https://crates.io/crates/quickcheck, I am redirected to the "This crate has been yanked" page (for version 0.4.2). However, we could just instead redirect to 0.4.1, the previous non-yanked version.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 21, 2017

related to #76

@pnkfelix
Copy link
Member

pnkfelix commented Mar 6, 2017

also related to (but distinct from) #145

@carols10cents
Copy link
Member

This has been fixed by the changes in #592 !

@carols10cents
Copy link
Member

carols10cents commented Mar 21, 2017

Ok, this is not fixed completely. If I navigate to https://crates.io/crates/quickcheck directly, I correctly end up on the page for quickcheck 0.4.1.

HOWEVER if I search for quickcheck and click the search result link, I still end up with a page that says "this crate has been yanked" page that says 0.4.2 :( Something's not hooked up the way ember needs it to be :(

@hoodie
Copy link

hoodie commented Mar 29, 2019

@carols10cents I'm still seeing this with actix right now

  1. last "stable" version is 0.7.10 (yanked)
  2. they just released 0.8.0-alpha.1
  3. suddenly the start page show "This crate has been yanked, but it is still available for download for other crates that may be depending on it."

@sgrif
Copy link
Contributor

sgrif commented Mar 29, 2019

@hoodie That's the expected behavior. crates.io/crates/actix shows the latest non-prerelease version, which has been yanked.

@sgrif
Copy link
Contributor

sgrif commented Mar 29, 2019

Scratch that, we should be redirecting to 0.7.9

@sgrif
Copy link
Contributor

sgrif commented Mar 29, 2019

This should be fixed by #1684 which I am deploying now

@sgrif
Copy link
Contributor

sgrif commented Mar 29, 2019

This appears to be fixed

@sgrif sgrif closed this as completed Mar 29, 2019
@Turbo87 Turbo87 removed the A-ui label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

7 participants