Implement async pagination #10021
Merged
Implement async pagination #10021
+297
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
eth3lbert
approved these changes
Nov 21, 2024
Comment on lines
+255
to
263
| pub fn load<'a, U>( | ||
| self, | ||
| conn: &'a mut AsyncPgConnection, | ||
| ) -> BoxFuture<'a, QueryResult<Paginated<U>>> | ||
| where | ||
| Self: LoadQuery<'a, Conn, WithCount<U>>, | ||
| Self: diesel_async::methods::LoadQuery<'a, AsyncPgConnection, WithCount<U>>, | ||
| T: 'a, | ||
| U: Send + 'a, | ||
| { |
There was a problem hiding this comment.
I admit that I'm unsure about whether the lifetime 'a here remains exactly the same as 'conn and 'query in diesel-async.
There was a problem hiding this comment.
no clue. I followed the suggestions of the compiler (when it wasn't crashing) and somehow made it work that way 😅
This allows the `FilterParams` struct to be `Send` which helps with migrating this endpoint to async/await.
… implementations
Turbo87
force-pushed
the
async-pagination
branch
from
64839b6
to
fb99e47
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10021 +/- ##
==========================================
- Coverage 89.22% 89.19% -0.04%
==========================================
Files 295 295
Lines 30784 30785 +1
==========================================
- Hits 27468 27459 -9
- Misses 3316 3326 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka. fighting with the borrow checker and internal compiler errors... 🙈
but hey, it compiles now and seems to work, so I guess that's good? 😆