Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/krate/publish: Migrate to diesel-async queries #10041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 21, 2024

finally...

now, unfortunately we still have a spawn_blocking() call in the endpoint since I didn't feel comfortable with processing the tarball on the async worker thread, but at least we're not using the AsyncConnectionWrapper wrapper anymore 🎉

This will allow us to throw away a bunch of duplicated code in some of the follow-up PRs :)

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 21, 2024
@Turbo87 Turbo87 requested a review from a team November 21, 2024 16:27
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 96.79144% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (45040bf) to head (2bad84c).

Files with missing lines Patch % Lines
src/controllers/krate/publish.rs 96.75% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10041      +/-   ##
==========================================
- Coverage   89.45%   88.94%   -0.51%     
==========================================
  Files         295      295              
  Lines       31475    31480       +5     
==========================================
- Hits        28156    28000     -156     
- Misses       3319     3480     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant