Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/diesel: Remove obsolete prelude module and Conn trait #10056

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

These are both not needed anymore now that we use diesel_async::{AsyncPgConnection, RunQueryDsl} everywhere.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
@Turbo87 Turbo87 enabled auto-merge November 22, 2024 11:07
@Turbo87 Turbo87 merged commit c865c0a into rust-lang:main Nov 22, 2024
8 checks passed
@Turbo87 Turbo87 deleted the diesel-util branch November 22, 2024 11:22
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (dfc30d0) to head (c67b728).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10056      +/-   ##
==========================================
- Coverage   89.51%   89.51%   -0.01%     
==========================================
  Files         295      295              
  Lines       31213    31211       -2     
==========================================
- Hits        27941    27939       -2     
  Misses       3272     3272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant