Backend of deployable chunk 1 of owner invitations #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
carols10cents
force-pushed
the
invitations
branch
from
93d8a4d
to
f9c6024
Compare
|
I'm not going to have the time to review this, I do like how you've split out the tests into |
Connects to rust-lang#959.
carols10cents
force-pushed
the
invitations
branch
from
f9c6024
to
b098509
Compare
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 6, 2017
1040: Backend of deployable chunk 1 of owner invitations r=carols10cents This adds a table for storing pending crate owner invitations and a backend route for listing the current user's invitations. I'll probably merge this later today if no one has time to review so that @natboehm can build off of this tomorrow :)
Build succeeded |
sgrif
reviewed
Sep 6, 2017
| .filter(crate_owner_invitations::invited_user_id.eq(user_id)) | ||
| .load::<CrateOwnerInvitation>(&*conn)? | ||
| .into_iter() | ||
| .map(|i| i.encodable(conn)) |
There was a problem hiding this comment.
This has an N+1 queries bug, doesn't it? Should we be selecting the crate and owner name along with the invitation?
There was a problem hiding this comment.
Oops. I'll fix it before we start linking to this page.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a table for storing pending crate owner invitations and a backend route for listing the current user's invitations.
I'll probably merge this later today if no one has time to review so that @natboehm can build off of this tomorrow :)