Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend of deployable chunk 1 of owner invitations #1040

Merged
merged 3 commits into from
Sep 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions migrations/2017-08-31-230457_invitations/down.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
DROP TABLE crate_owner_invitations;
7 changes: 7 additions & 0 deletions migrations/2017-08-31-230457_invitations/up.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
CREATE TABLE crate_owner_invitations (
invited_user_id INTEGER NOT NULL REFERENCES users (id) ON DELETE CASCADE,
invited_by_user_id INTEGER NOT NULL REFERENCES users (id) ON DELETE CASCADE,
crate_id INTEGER NOT NULL REFERENCES crates (id) ON DELETE CASCADE,
created_at TIMESTAMP NOT NULL DEFAULT now(),
PRIMARY KEY (invited_user_id, crate_id)
);
82 changes: 82 additions & 0 deletions src/crate_owner_invitation.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
use conduit::{Request, Response};
use diesel::prelude::*;
use time::Timespec;

use db::RequestTransaction;
use schema::{crate_owner_invitations, users, crates};
use user::RequestUser;
use util::errors::CargoResult;
use util::RequestUtils;

/// The model representing a row in the `crate_owner_invitations` database table.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Identifiable, Queryable)]
#[primary_key(invited_user_id, crate_id)]
pub struct CrateOwnerInvitation {
pub invited_user_id: i32,
pub invited_by_user_id: i32,
pub crate_id: i32,
pub created_at: Timespec,
}

#[derive(Insertable, Clone, Copy, Debug)]
#[table_name = "crate_owner_invitations"]
pub struct NewCrateOwnerInvitation {
pub invited_user_id: i32,
pub invited_by_user_id: i32,
pub crate_id: i32,
}

impl CrateOwnerInvitation {
pub fn invited_by_username(&self, conn: &PgConnection) -> String {
users::table
.find(self.invited_by_user_id)
.select(users::gh_login)
.first(&*conn)
.unwrap_or_else(|_| String::from("(unknown username)"))
}

pub fn crate_name(&self, conn: &PgConnection) -> String {
crates::table
.find(self.crate_id)
.select(crates::name)
.first(&*conn)
.unwrap_or_else(|_| String::from("(unknown crate name)"))
}

pub fn encodable(self, conn: &PgConnection) -> EncodableCrateOwnerInvitation {
EncodableCrateOwnerInvitation {
invited_by_username: self.invited_by_username(conn),
crate_name: self.crate_name(conn),
crate_id: self.crate_id,
created_at: ::encode_time(self.created_at),
}
}
}

/// The serialization format for the `CrateOwnerInvitation` model.
#[derive(Deserialize, Serialize, Debug)]
pub struct EncodableCrateOwnerInvitation {
pub invited_by_username: String,
pub crate_name: String,
pub crate_id: i32,
pub created_at: String,
}

/// Handles the `GET /me/crate_owner_invitations` route.
pub fn list(req: &mut Request) -> CargoResult<Response> {
let conn = &*req.db_conn()?;
let user_id = req.user()?.id;

let invitations = crate_owner_invitations::table
.filter(crate_owner_invitations::invited_user_id.eq(user_id))
.load::<CrateOwnerInvitation>(&*conn)?
.into_iter()
.map(|i| i.encodable(conn))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has an N+1 queries bug, doesn't it? Should we be selecting the crate and owner name along with the invitation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I'll fix it before we start linking to this page.

.collect();

#[derive(Serialize)]
struct R {
invitations: Vec<EncodableCrateOwnerInvitation>,
}
Ok(req.json(&R { invitations }))
}
5 changes: 5 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ pub mod badge;
pub mod categories;
pub mod category;
pub mod config;
pub mod crate_owner_invitation;
pub mod db;
pub mod dependency;
pub mod dist;
Expand Down Expand Up @@ -183,6 +184,10 @@ pub fn middleware(app: Arc<App>) -> MiddlewareBuilder {
api_router.get("/me/tokens", C(token::list));
api_router.post("/me/tokens", C(token::new));
api_router.delete("/me/tokens/:id", C(token::revoke));
api_router.get(
"/me/crate_owner_invitations",
C(crate_owner_invitation::list),
);
api_router.get("/summary", C(krate::summary));
let api_router = Arc::new(R404(api_router));

Expand Down
33 changes: 33 additions & 0 deletions src/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,38 @@ table! {
}
}

table! {
/// Representation of the `crate_owner_invitations` table.
///
/// (Automatically generated by Diesel.)
crate_owner_invitations (invited_user_id, crate_id) {
/// The `invited_user_id` column of the `crate_owner_invitations` table.
///
/// Its SQL type is `Int4`.
///
/// (Automatically generated by Diesel.)
invited_user_id -> Int4,
/// The `invited_by_user_id` column of the `crate_owner_invitations` table.
///
/// Its SQL type is `Int4`.
///
/// (Automatically generated by Diesel.)
invited_by_user_id -> Int4,
/// The `crate_id` column of the `crate_owner_invitations` table.
///
/// Its SQL type is `Int4`.
///
/// (Automatically generated by Diesel.)
crate_id -> Int4,
/// The `created_at` column of the `crate_owner_invitations` table.
///
/// Its SQL type is `Timestamp`.
///
/// (Automatically generated by Diesel.)
created_at -> Timestamp,
}
}

table! {
/// Representation of the `crate_owners` table.
///
Expand Down Expand Up @@ -720,3 +752,4 @@ joinable!(version_downloads -> versions (version_id));
joinable!(crate_owners -> teams (owner_id));
joinable!(crate_owners -> users (owner_id));
joinable!(readme_rendering -> versions (version_id));
joinable!(crate_owner_invitations -> crates (crate_id));
27 changes: 24 additions & 3 deletions src/tests/all.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ use cargo_registry::app::App;
use cargo_registry::category::NewCategory;
use cargo_registry::dependency::NewDependency;
use cargo_registry::keyword::Keyword;
use cargo_registry::krate::{NewCrate, CrateDownload};
use cargo_registry::schema::dependencies;
use cargo_registry::krate::{NewCrate, CrateDownload, EncodableCrate};
use cargo_registry::schema::*;
use cargo_registry::upload as u;
use cargo_registry::user::NewUser;
use cargo_registry::owner::{CrateOwner, NewTeam, Team};
Expand All @@ -43,7 +43,6 @@ use conduit::{Request, Method};
use conduit_test::MockRequest;
use diesel::prelude::*;
use diesel::pg::upsert::*;
use cargo_registry::schema::*;

macro_rules! t {
($e:expr) => (
Expand Down Expand Up @@ -89,13 +88,35 @@ mod category;
mod git;
mod keyword;
mod krate;
mod owners;
mod record;
mod schema_details;
mod team;
mod token;
mod user;
mod version;

#[derive(Deserialize)]
struct GoodCrate {
#[serde(rename = "crate")]
krate: EncodableCrate,
warnings: Warnings,
}
#[derive(Deserialize)]
struct CrateList {
crates: Vec<EncodableCrate>,
meta: CrateMeta,
}
#[derive(Deserialize)]
struct Warnings {
invalid_categories: Vec<String>,
invalid_badges: Vec<String>,
}
#[derive(Deserialize)]
struct CrateMeta {
total: i32,
}

fn app() -> (record::Bomb, Arc<App>, conduit_middleware::MiddlewareBuilder) {
dotenv::dotenv().ok();
git::init();
Expand Down
Loading