WIP: Trusted Publishing #11056
Draft
WIP: Trusted Publishing #11056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
commented
Apr 24, 2025
src/tests/krate/publish/oidc.rs
Outdated
| /// 3. Generate a new OIDC token and exchange it for a temporary access token. | ||
| /// 4. Publish a new version of the crate using the temporary access token. | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn test_full_flow() -> anyhow::Result<()> { |
There was a problem hiding this comment.
if you want to start your review somewhere, this is probably the right place for a high level overview :)
Turbo87
force-pushed
the
trusted-publishing
branch
6 times, most recently
from
9f5267e to
607a12a
Compare
Turbo87
force-pushed
the
trusted-publishing
branch
12 times, most recently
from
986a71d to
96bf257
Compare
Turbo87
force-pushed
the
trusted-publishing
branch
from
96bf257 to
f1a8144
Compare
This fn can be used to decode a JSON web token without verifying it's signature or claims. Only the `iss` claim will actually be decoded, since we use that to find the correct decoding key for the JWT issuer.
Turbo87
force-pushed
the
trusted-publishing
branch
from
f1a8144 to
451684a
Compare
This defaults to the domain name (crates.io / staging.crates.io) and controls the expected `aud` claim of the OIDC JWT in the Trusted Publishing token exchange.
…lishing providers
This makes it possible to construct `MockTokenUser` instances from an existing plaintext token.
…n optional This "Trusted Publishing" the CI service performs the publishing, so there is no corresponding email address in that case.
Turbo87
force-pushed
the
trusted-publishing
branch
from
451684a to
62cb7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should eventually implement the backend API part of the "Trusted Publishing" RFC (see #10247 and rust-lang/rfcs#3691).
It is currently very much work in progress and only opened to simplify reviews for some of the early architectural decisions. Yes, the
publishendpoint is very messy. It is not the final state of the proposed changes 😉