Explicitly state our license in the README, use OR in Cargo.toml
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked and package.json already contains Would you update src/s3/Cargo.toml as well? |
|
bors: r+ |
Build succeeded |
wking
added a commit
to wking/license-exprs
that referenced
this pull request
Jan 11, 2018
Catch up with the recommendations from rust-lang/cargo@7dee65fe (src/doc/manifest: Pin 'license' to SPDX 2.1 expressions and the 2.4 list, 2018-01-04, rust-lang/cargo#4898), which deprecated '/' in favor of vanilla SPDX license expressions. I've gone with the disjunctive OR, and most contributors have signed off on that change: * Without Boats wanted to match the crates.io licensing [1], and they meant OR [2]. * Rodolphe Breard [3] and Laurence Tratt [4] intended OR. We haven't heard back from Kai NODA, but ed9fe0b (README.md: update the reference to SPDX, 2017-07-14, ehuss#8) is probably too small to be copyrightable. [1]: ehuss#14 (comment) [2]: rust-lang/crates.io#1226 [3]: ehuss#14 (comment) [4]: ehuss#14 (comment)
wking
added a commit
to wking/license-exprs
that referenced
this pull request
Jan 11, 2018
Catch up with the recommendations from rust-lang/cargo@7dee65fe (src/doc/manifest: Pin 'license' to SPDX 2.1 expressions and the 2.4 list, 2018-01-04, rust-lang/cargo#4898), which deprecated '/' in favor of vanilla SPDX license expressions. I've gone with the disjunctive OR, and most contributors have signed off on that change: * Without Boats wanted to match the crates.io licensing [1], and they meant OR [2]. * Rodolphe Breard [3], Laurence Tratt [4], and Kai NODA [5] intended OR. [1]: ehuss#14 (comment) [2]: rust-lang/crates.io#1226 [3]: ehuss#14 (comment) [4]: ehuss#14 (comment) [5]: ehuss#14 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1225