Split keyword and category functionality into MVC units #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Feb 1, 2018
1247: Split keyword and category functionality into MVC units r=carols10cents This PR is based on #1155 which is not yet merged to master. This [comparison](jtgeibel/crates.io@add-mvc-modules...jtgeibel:mvc-keyword-and-category) shows just the changes built on top of that branch. This PR moves the request handlers for keyword and category functionality to the `controllers` module. I extracted the common `use` statements into a `controllers::prelude`. `Encodable*` structs and the rfc3339 tests are moved under `views` and the remaining model structs, impls, and tests are moved under `models`.
Build succeeded |
|
Thanks @carols10cents! I hope to have a few in the pipeline soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1155 which is not yet merged to master. This comparison shows just the changes built on top of that branch.
This PR moves the request handlers for keyword and category functionality to the
controllersmodule. I extracted the commonusestatements into acontrollers::prelude.Encodable*structs and the rfc3339 tests are moved underviewsand the remaining model structs, impls, and tests are moved undermodels.