WIP: When searching order crates by last update date #1426
Conversation
| crates: Vec<EncodableCrate>, | ||
| meta: Meta, | ||
| #[cfg(test)] | ||
| mod test { |
There was a problem hiding this comment.
Should this live with the rest of the integration tests, rather than re-implementing half of it here?
There was a problem hiding this comment.
Are you talking about the builder or the tests?
| sort.to_string(), | ||
| current_user_id, | ||
| ); | ||
| let total = crates.len() as i64; |
There was a problem hiding this comment.
This is not correct. The query is running the equivalent of SELECT crates.*, recent_downloads.downloads, COUNT(*) OVER (). total is the number of crates that could be returned without pagination, not the number returned by the query.
| })) | ||
| } | ||
|
|
||
| fn execute_search( |
There was a problem hiding this comment.
I'm not sure why this needed to be split into a separate function.
There was a problem hiding this comment.
This was split to make it easier to create unit tests for this part of the code.
|
I want to apologize for the delay in answering your questions, providing feedback, and generally moving this PR forward-- I haven't been a great maintainer lately. Since this PR was opened, we have done quite a bit of refactoring that I think has improved the codebase, but unfortunately has made updating PRs a bit tricky. I feel bad about this too, and normally I would take on the work of resolving merge conflicts. However, in order to try to get out from under the backlog of PRs that are outstanding, I've decided to aggressively close outdated PRs rather than update them. At this point it would probably take less time to reimplement the work rather than fix merge conflicts. I appreciate the work you've put in here, and again I sincerely apologize for my lack of response. If you would like to work on this again in the future, I would be honored, but I also totally understand if you'd rather not. Thank you! |
Closes #1210