Allow a new macro hygiene lint until we get Diesel 1.4 #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we deny warnings, this new lint will cause our CI to fail once it hits beta. Allowing `unknown_lints` is necessary because stable-1.28 isn't aware of this lint. This patch can be reverted as part of upgrading to Diesel 1.4 once that is released. See the [upstream PR] for more information. [upstream PR]: diesel-rs/diesel#1787
|
I'm going to go ahead and merge this so that master builds cleanly on nightly. The plan is to revert this commit as part of our next Diesel upgrade. bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 2, 2018
1469: Allow a new macro hygiene lint until we get Diesel 1.4 r=jtgeibel a=jtgeibel Because we deny warnings, this new lint will cause our CI to fail once it hits beta. Allowing `unknown_lints` is necessary because stable-1.28 isn't aware of this lint. This patch can be reverted as part of upgrading to Diesel 1.4 once that is released. See the [upstream PR] for more information. [upstream PR]: diesel-rs/diesel#1787 Co-authored-by: Justin Geibel <jtgeibel@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we deny warnings, this new lint will cause our CI to fail once
it hits beta. Allowing
unknown_lintsis necessary becausestable-1.28 isn't aware of this lint.
This patch can be reverted as part of upgrading to Diesel 1.4 once that
is released. See the upstream PR for more information.