Skip to content

Fix user links CSS #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2015
Merged

Fix user links CSS #147

merged 1 commit into from
Apr 23, 2015

Conversation

gentoo90
Copy link
Contributor

Before After
before after

@tomaka
Copy link
Contributor

tomaka commented Apr 21, 2015

Ah! This problem has been bothering me for months! ❤️

@alexcrichton
Copy link
Member

Hm when I shrink the size of the windows to be very skinny this causes the menu to look a little funny. The current rendering also looks good to me on Firefox at least. What browser are you using?

@gentoo90
Copy link
Contributor Author

Firefox. Fixed:
after2

@alexcrichton
Copy link
Member

Hm the text still looks a little scrunched to me on Firefox with a smaller screen:

Before:

https://i.imgur.com/vE69aam.png

After:

https://i.imgur.com/5FA1ria.png

Is the min-width property still necessary? (removing that made it look ok). To clarify, what browser are you using to view the changes here?

@gentoo90
Copy link
Contributor Author

OK, now I found it, this small-screen menu already has min-width in its style, and it's 200px.

what browser are you using to view the changes here?

Firefox and Chrome.

@gentoo90
Copy link
Contributor Author

Is the min-width property still necessary?

Yes, without it user menu still look like this
before

@alexcrichton
Copy link
Member

Ah ok, with the higher min-width this looks fine to me, thanks!

alexcrichton added a commit that referenced this pull request Apr 23, 2015
@alexcrichton
Merge pull request #147 from gentoo90/user-links-fix
a5c44df 
Fix user links CSS
@alexcrichton alexcrichton merged commit a5c44df into rust-lang:master Apr 23, 2015
bors added a commit that referenced this pull request Dec 17, 2019
@bors
Auto merge of #1965 - rust-lang:dependabot/npm_and_yarn/ember-page-ti…
1fe2513 
…tle-5.1.0, r=locks

Bump ember-page-title from 4.0.5 to 5.1.0

Bumps [ember-page-title](https://github.com/adopted-ember-addons/ember-page-title) from 4.0.5 to 5.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-page-title's releases](https://github.com/adopted-ember-addons/ember-page-title/releases).*

> ## 5.1.0
> Add a `front` argument to place the title at the front
>
> ## 5.0.2
> Update dependencies
>
> ## 5.0.1
> - Resolves Ember 3.6 deprecations
> - Readme updated to reflect new location
> - Docs site link updated
>
> ## 5.0.0
> 🚨 `prepend` is now `true` by default!
>
> ❤️  Thanks to [@&#8203;ondrejsevcik](https://github.com/ondrejsevcik) for this change! For reasoning behind this, I'll quote them directly:
>
> > With a limited space to show in a page title, it's a best practice to put current page title first. Otherwise you end up with a title where you can't clearly see what page are you in. This is especially issue when you have nested pages with long titles.
>
</details>
<details>
<summary>Commits</summary>

- [`b5338ef`](ember-cli/ember-page-title@b5338ef) Release 5.1.0
- [`f4e643f`](ember-cli/ember-page-title@f4e643f) feat: Make it possible to specify that a token should ALWAYS be in front ([#152](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/152))
- [`d32c4e9`](ember-cli/ember-page-title@d32c4e9) Release 5.0.2
- [`47f759a`](ember-cli/ember-page-title@47f759a) Merge pull request [#150](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/150) from efx/fix-remove-kruft
- [`2c7fd67`](ember-cli/ember-page-title@2c7fd67) remove ember-cli-release configuration
- [`b3a240c`](ember-cli/ember-page-title@b3a240c) Merge pull request [#149](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/149) from efx/fix-ember-try
- [`0c62597`](ember-cli/ember-page-title@0c62597) fix ember try command
- [`04f1e5a`](ember-cli/ember-page-title@04f1e5a) Merge pull request [#146](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/146) from efx/no-var
- [`a9bd983`](ember-cli/ember-page-title@a9bd983) Merge branch 'latest' into no-var
- [`5eb7775`](ember-cli/ember-page-title@5eb7775) Merge pull request [#147](https://github-redirect.dependabot.com/adopted-ember-addons/ember-page-title/issues/147) from efx/update-ember-cli
- Additional commits viewable in [compare view](ember-cli/ember-page-title@4.0.5...5.1.0)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [knownasilya](https://www.npmjs.com/~knownasilya), a new releaser for ember-page-title since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-page-title&package-manager=npm_and_yarn&previous-version=4.0.5&new-version=5.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-page-title&package-manager=npm_and_yarn&previous-version=4.0.5&new-version=5.1.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gentoo90 @tomaka @alexcrichton